-
Notifications
You must be signed in to change notification settings - Fork 40
[1092] Using MLFlow in the main repo #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| readme = "../../README.md" | ||
| requires-python = ">=3.12,<3.13" | ||
| dependencies = [ | ||
| "mlflow", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe mlflow-skinny would work
| channels_set = collect_channels(scores_dict, metric, region, runs) | ||
|
|
||
| for run_id, metrics_dict in reordered_dict.items(): | ||
| parent_run = get_or_create_mlflow_parent_run(mlflow_client, run_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem is the run_id here, which is the inference run.the easiest is probably to query mlflow to find the value of the tag tags.from_run_id (which will be the model).
This or reading the config for this run. I think it will be more complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we should keep the inference run_id in the name or rather have it in the metadata. On the other hand might be good to keep it in the name in case of several inference instances...

Description
Issue Number
Refs #1092
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60